Update fcs to 43.8.200 preview.23516.2 (#1202)

.config/dotnet-tools.json

@@ -15,7 +15,7 @@
       ]
     },
     "fantomas": {
-      "version": "6.2.2",
+      "version": "6.2.3",
       "commands": [
         "fantomas"
       ]

.github/workflows/build.yml

@@ -65,11 +65,11 @@ jobs:
 
     # setup .NET per the repo global.json
     - name: Setup .NET
-      uses: actions/setup-dotnet@v2
+      uses: actions/setup-dotnet@v3
 
     # setup .NET per test session
     - name: Setup .NET
-      uses: actions/setup-dotnet@v2
+      uses: actions/setup-dotnet@v3
       with:
         include-prerelease: ${{ matrix.include-prerelease }}
         global-json-file: ${{ matrix.global-json-file }}
@@ -87,7 +87,10 @@ jobs:
       run: |
         # can't do a tool restore here due to an 8.0.100 rc2 bug - this is fixed in GA so can go back to
         # dotnet tool restore then.
-        dotnet tool install paket --version 8.0.0-alpha002 && dotnet tool install fantomas --version 6.2.2 && dotnet paket restore
+        dotnet tool install paket --version 8.0.0-alpha002 && dotnet tool install fantomas --version 6.2.3 && dotnet paket restore
+
+    - name: cat file
+      run: cat src/FsAutoComplete.Core/AbstractClassStubGenerator.fs
 
     - name: Check format
       run: dotnet build -t:CheckFormat

paket.dependencies

@@ -4,7 +4,7 @@ framework: netstandard2.0, netstandard2.1,  net6.0, net7.0, net8.0
 
 source https://api.nuget.org/v3/index.json
 # this is the FCS nightly feed, re-enable at your own risk!
-# source: https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json
+source: https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json
 #source: ./libs
 storage: none
 strategy: min
@@ -13,7 +13,7 @@ lowest_matching: true
 
 nuget BenchmarkDotNet 0.13.5
 nuget Fantomas.Client >= 0.9
-nuget FSharp.Compiler.Service >= 43.8.100
+nuget FSharp.Compiler.Service >= 43.8.200-preview.23562.1
 nuget Ionide.ProjInfo >= 0.62.0
 nuget Ionide.ProjInfo.FCS >= 0.62.0
 nuget Ionide.ProjInfo.ProjectSystem >= 0.62.0

paket.lock

@@ -59,22 +59,12 @@ NUGET
       FSharp.Compiler.Service (>= 41.0.1) - restriction: || (== net6.0) (== net7.0) (== net8.0) (&& (== netstandard2.0) (>= net5.0)) (&& (== netstandard2.1) (>= net5.0))
       FSharp.Core (>= 6.0.1) - restriction: || (== net6.0) (== net7.0) (== net8.0) (&& (== netstandard2.0) (>= net5.0)) (&& (== netstandard2.1) (>= net5.0))
       McMaster.NETCore.Plugins (>= 1.4) - restriction: || (== net6.0) (== net7.0) (== net8.0) (&& (== netstandard2.0) (>= net5.0)) (&& (== netstandard2.1) (>= net5.0))
-    FSharp.Compiler.Service (43.8.100)
-      FSharp.Core (8.0.100)
-      System.Buffers (>= 4.5.1)
-      System.Collections.Immutable (>= 7.0)
-      System.Diagnostics.DiagnosticSource (>= 7.0.2)
-      System.Memory (>= 4.5.5)
-      System.Reflection.Emit (>= 4.7)
-      System.Reflection.Metadata (>= 7.0)
-      System.Runtime.CompilerServices.Unsafe (>= 6.0)
     FSharp.Control.AsyncSeq (3.2.1)
       FSharp.Core (>= 4.7.2)
       Microsoft.Bcl.AsyncInterfaces (>= 5.0)
     FSharp.Control.Reactive (5.0.5) - restriction: || (== net6.0) (== net7.0) (== net8.0) (&& (== netstandard2.0) (>= net6.0)) (&& (== netstandard2.1) (>= net6.0))
       FSharp.Core (>= 4.7.2)
       System.Reactive (>= 5.0 < 6.0)
-    FSharp.Core (8.0.100)
     FSharp.Data.Adaptive (1.2.13)
       FSharp.Core (>= 4.7)
       System.Reflection.Emit.Lightweight (>= 4.6)
@@ -489,6 +479,17 @@ NUGET
       Expecto (>= 10.0 < 11.0) - restriction: || (== net6.0) (== net7.0) (== net8.0) (&& (== netstandard2.0) (>= net6.0)) (&& (== netstandard2.1) (>= net6.0))
       FSharp.Core (>= 7.0.200) - restriction: || (== net6.0) (== net7.0) (== net8.0) (&& (== netstandard2.0) (>= net6.0)) (&& (== netstandard2.1) (>= net6.0))
       System.Collections.Immutable (>= 6.0) - restriction: || (== net6.0) (== net7.0) (== net8.0) (&& (== netstandard2.0) (>= net6.0)) (&& (== netstandard2.1) (>= net6.0))
+  remote: https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json
+    FSharp.Compiler.Service (43.8.200-preview.23562.1)
+      FSharp.Core (8.0.200-beta.23562.1)
+      System.Buffers (>= 4.5.1)
+      System.Collections.Immutable (>= 7.0)
+      System.Diagnostics.DiagnosticSource (>= 7.0.2)
+      System.Memory (>= 4.5.5)
+      System.Reflection.Emit (>= 4.7)
+      System.Reflection.Metadata (>= 7.0)
+      System.Runtime.CompilerServices.Unsafe (>= 6.0)
+    FSharp.Core (8.0.200-beta.23562.1)
 
 GROUP Build
 STORAGE: NONE

src/FsAutoComplete.Core/FileSystem.fs

@@ -347,6 +347,11 @@ module RoslynSourceText =
 
       member _.GetSubTextString(start, length) = sourceText.GetSubText(TextSpan(start, length)).ToString()
 
+      member x.GetSubTextFromRange(range: range) : string =
+        match (x :> IFSACSourceText).GetText(range) with
+        | Ok t -> t
+        | _ -> invalidArg (nameof range) "The range is outside the file boundaries"
+
       member _.SubTextEquals(target, startIndex) =
         if startIndex < 0 || startIndex >= sourceText.Length then
           invalidArg "startIndex" "Out of range."