Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Fixes #1148

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Various Fixes #1148

merged 4 commits into from
Jul 28, 2023

Conversation

TheAngryByrd
Copy link
Member

@TheAngryByrd TheAngryByrd commented Jul 27, 2023

WHAT

🤖 Generated by Copilot at fb73003

This pull request enhances the LSP server, fixes a line count bug, removes an unused field, and improves the performance of inlay hints. It uses the IFSACSourceText interface more consistently and simplifies some error handling and progress reporting logic. It affects the files AdaptiveFSharpLspServer.fs, Commands.fs, FileSystem.fs, and InlayHints.fs.

🤖 Generated by Copilot at fb73003

docForText fixed
Analyzers and LSP improved
Autumn of refactoring

🐛🔥🚀

WHY

HOW

🤖 Generated by Copilot at fb73003

@TheAngryByrd TheAngryByrd self-assigned this Jul 27, 2023
Copy link
Contributor

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - hooray for using text manipulation helpers more generally

@baronfel baronfel merged commit d215e76 into ionide:main Jul 28, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants