Convert Result string Error Handling to Option Where Applicable #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1eyewonder
changed the title
… functions to handle options types
AdaptiveFSharpLspServer.fs
|
Closing because I realized I didn't pay attention towards the end of the Amplifying FSharp video. #1195 already tackles the main function I was refactoring but uses Result instead of Option. For my sanity I am going to close this PR and open a new one with different snippets I found during mind findings in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at da3703a
This pull request refactors the error handling logic in various modules of the FsAutoComplete project to use option types instead of result types and strings for errors. It also adds a new dependency to the
FsToolkit.ErrorHandlinglibrary, which provides some utilities for functional error handling in F#. The main goal of this refactoring is to simplify the code and make it more consistent and expressive. The affected modules includeCommands,CodeFixes,AdaptiveFSharpLspServer, andAdaptiveState. The affected files includesrc/FsAutoComplete.Core/Commands.fs,src/FsAutoComplete/CodeFixes.fs,src/FsAutoComplete/CodeFixes.fsi,src/FsAutoComplete/CodeFixes/RemoveUnusedOpens.fs,src/FsAutoComplete/LspServers/AdaptiveFSharpLspServer.fs,src/FsAutoComplete/LspServers/AdaptiveServerState.fs,src/FsAutoComplete/LspServers/AdaptiveServerState.fsi,paket.dependencies,src/FsAutoComplete.Core/paket.references,src/FsAutoComplete/CodeFixes/AddPrivateAccessModifier.fs,src/FsAutoComplete/CodeFixes/AddPrivateAccessModifier.fsi, andsrc/FsAutoComplete/LspServers/Common.fs.🤖 Generated by Copilot at da3703a
📦🛠️🚀
WHY
HOW
🤖 Generated by Copilot at da3703a
FsToolkit.ErrorHandlinglibrary (link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link) in filessrc/FsAutoComplete.Core/Commands.fs,src/FsAutoComplete/CodeFixes.fs,src/FsAutoComplete/CodeFixes.fsi,src/FsAutoComplete/CodeFixes/AddPrivateAccessModifier.fs,src/FsAutoComplete/CodeFixes/AddPrivateAccessModifier.fsi,src/FsAutoComplete/CodeFixes/RemoveUnusedOpens.fs,src/FsAutoComplete/LspServers/AdaptiveFSharpLspServer.fs,src/FsAutoComplete/LspServers/AdaptiveServerState.fs, andsrc/FsAutoComplete/LspServers/AdaptiveServerState.fsi.