Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ISourceTextFactory/IFSharpLspServer from test names #1205

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Nov 16, 2023

…codebase, let's have simpler test names

WHAT

🤖[deprecated] Generated by Copilot at e9f83ce

This pull request simplifies and refactors the LSP test code by using a consistent RoslynSourceTextFactory for creating source texts and removing unnecessary parameters and test cases. It affects the files InlayHintTests.fs, Program.fs, and FindReferencesTests.fs.

🤖[deprecated] Generated by Copilot at e9f83ce

We are the Roslyn legion, we forge the source of truth
We purge the useless parameters, we streamline the test of proof
We unify the LSP server, we crush the code complexity
We are the Roslyn legion, we reign in text analysis

🔥🎨🔧

WHY

Now wIth only one ISourceTextFactory and one IFSharpLspServer implementation in the codebase, let's have simpler test names.
Of course, this only makes sense without plans to have multiple implementations again. If there are plans, ignore this PR :)

HOW

🤖[deprecated] Generated by Copilot at e9f83ce

  • Simplify the test infrastructure by using a fixed source text factory and LSP server implementation (link, link, link, link, link)

Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Definitely missed this in my big refactoring pass.

Probably unrelated but why are some format checks failing occasionally?

@dawedawe
Copy link
Contributor Author

Good question. The failings are jumping randomly between 6/7/8 and OS.
So my guess is something funky on the GH instances. But I have no idea how to debug this further.

@TheAngryByrd TheAngryByrd merged commit eaa9e0b into ionide:main Nov 20, 2023
10 of 12 checks passed
@dawedawe dawedawe deleted the testnamecleanup branch November 20, 2023 17:39
1eyewonder pushed a commit to 1eyewonder/FsAutoComplete that referenced this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants