Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fcs 43.8.100 stable #1206

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Fcs 43.8.100 stable #1206

merged 3 commits into from
Nov 16, 2023

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Nov 16, 2023

WHAT

🤖[deprecated] Generated by Copilot at a0193ec

This pull request updates a dependency, fixes a bug in a code fix feature, and improves the formatting of a file. The bug fix prevents a stack overflow exception when adjusting constants with measure annotations in AdjustConstant.fs.

🤖[deprecated] Generated by Copilot at a0193ec

findConst bug fixed
No more stack overflow woes
Winter code is warm

🐛🔧📝

WHY

HOW

🤖[deprecated] Generated by Copilot at a0193ec

  • Fix a bug in findConst that caused a stack overflow when adjusting a constant with a measure annotation (link)
  • Use the stable version of FSharp.Compiler.Service instead of the nightly build to avoid potential instability or incompatibility issues (link)
  • Add a space after the comment symbol in paket.dependencies to follow the formatting convention of the file (link)

@nojaf nojaf changed the base branch from main to nightly November 16, 2023 10:18
Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheAngryByrd TheAngryByrd merged commit 9cf7b31 into ionide:nightly Nov 16, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants