Additional warn on #1207
Merged
Additional warn on #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
force-pushed
the
additional-warn-on
branch
from
ad118b4 to
e3d5229
Compare
nojaf
force-pushed
the
additional-warn-on
branch
from
167e62a to
2868831
Compare
baronfel
reviewed
Nov 16, 2023
|
Thanks for doing this code cleanup :) |
|
Thank you Chester! For everything! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖[deprecated] Generated by Copilot at ad118b4
This pull request improves the code quality, readability, and performance of the FsAutoComplete language server by simplifying and cleaning up various pattern matching expressions, removing unused or redundant parameters, variables, and bindings, updating the FCS dependency, adding a new benchmark, and enabling some compiler warnings. The affected files include
SourceText.LineChanges,AbstractClassStubGenerator,AdaptiveExtensions,Commands,CompilerServiceInterface,DocumentationFormatter,FCSPatches,InlayHints,ParseAndCheckResults,State,TypedAstPatterns,UnionPatternMatchCaseGenerator,build/Program.fs,Directory.Build.props,CodeGeneration,Debug,DotnetNewTemplate,Fsdn, andTypedAstUtils.🤖[deprecated] Generated by Copilot at ad118b4
🧹🚀🛠️
WHY
HOW
🤖[deprecated] Generated by Copilot at ad118b4
SourceText.LineChangesfunction (link)InlayHintsmodule (link)I'd like to enable warnings on FS1182.
0297eda would have been discovered instantly if this was enabled.