Fix reference count positions #1319
Conversation
| @@ -1437,12 +1452,17 @@ type AdaptiveState | |||
| asyncAVal { | |||
| let wins = | |||
| openFilesToChangesAndProjectOptions | |||
| |> AMap.map (fun _k v -> v |> AsyncAVal.mapSync (fun (_, projects) _ -> projects)) | |||
There was a problem hiding this comment.
The main issue here is the calls to parseFile weren't happening after file changes because of how F# Data Adaptive works when caching values. Even if something changes upstream (like file changes), the list of projects was staying the same and causing us to use stale parsechecks.
There was a problem hiding this comment.
This makes sure to allow the file changes to pass thru so we can use them correctly for updates.
TheAngryByrd
force-pushed
the
2019-reference-counts-position-incorrect
branch
from
86aec8a
to
d204b8e
Compare
TheAngryByrd
force-pushed
the
2019-reference-counts-position-incorrect
branch
from
176e7cc
to
4c5a7b6
Compare
|
Great! Merge and release ASAP? |
|
I'm being responsible parent here and asking for a test to prevent regressing this (because @TheAngryByrd thinks a simple refactoring regressed this behavior):
|
| } | ||
| |> AsyncResult.foldResult id (fun e -> failtest $"{e}") | ||
|
|
||
|
|
||
| let projectBasedTests state = | ||
| testList "ProjectBased" [ | ||
| serverTestList ("CodeLensPositionStaysAccurate") state defaultConfigDto (Some CodeLens.CodeLensPositionStaysAccurate.dir) (fun server -> [ |
There was a problem hiding this comment.
Tests added.
Fails with only BackgroundCompiler on older version of src/FsAutoComplete/LspServers/AdaptiveServerState.fs.
When we were testing on discord, we discovered it was only failing for background compiler and not transparent (this is because the project workspace handles this file update mechanism differently)
| let getLenses (doc: Document) = | ||
| let p: CodeLensParams = | ||
| { TextDocument = doc.TextDocumentIdentifier | ||
| PartialResultToken = None | ||
| WorkDoneToken = None } | ||
|
|
||
| doc.Server.Server.TextDocumentCodeLens p | ||
| |> AsyncResult.mapError string | ||
| |> AsyncResult.map (fun r -> r |> Option.defaultValue [||]) | ||
|
|
||
| let getResolvedLenses (doc: Document) lenses = | ||
| lenses | ||
| |> List.ofArray | ||
| |> List.traverseAsyncResultA doc.Server.Server.CodeLensResolve | ||
| |> AsyncResult.mapError string |
There was a problem hiding this comment.
Mostly refactoring and mechanical changes here
TheAngryByrd
force-pushed
the
2019-reference-counts-position-incorrect
branch
from
34cc98a
to
72eb03e
Compare
|
Awesome - merging. Want to try and take this one and 1309 in the next release. |
Fixes ionide/ionide-vscode-fsharp#2019
Before:
codelens-references-broken.mp4
After:
codelens-references-fixed.mp4