Clean up

.config/dotnet-tools.json

@@ -2,8 +2,8 @@
   "version": 1,
   "isRoot": true,
   "tools": {
-    "fantomas-tool": {
-      "version": "4.6.0-beta-001",
+    "fantomas": {
+      "version": "6.3.0-alpha-003",
       "commands": [
         "fantomas"
       ]

.editorconfig

@@ -0,0 +1,15 @@
+root = true
+
+[*.{fs,fsi,fsx}]
+end_of_line = lf
+fsharp_keep_max_number_of_blank_lines = 1
+fsharp_multi_line_lambda_closing_newline = true
+fsharp_alternative_long_member_definitions = true
+fsharp_align_function_signature_to_indentation = true
+fsharp_experimental_keep_indent_in_branch = true
+fsharp_bar_before_discriminated_union_declaration = true
+fsharp_multiline_bracket_style = aligned
+
+# Expecto looks a bit nicer with stroustrup
+[test/**/*.fs]
+fsharp_multiline_bracket_style = stroustrup

.gitattributes

@@ -0,0 +1,7 @@
+# Automatically normalize line endings
+* text=auto
+
+# Always use lf for F# files
+*.fs text eol=lf
+*.fsx text eol=lf
+*.fsi text eol=lf

.github/dependabot.yml

@@ -0,0 +1,14 @@
+version: 2
+updates:
+
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+
+  - package-ecosystem: "nuget"
+    directory: "/"
+    schedule:
+      interval: "daily"
+    ignore:
+      - dependency-name: "FSharp.Core"

.github/workflows/buildAndTest.yml

@@ -12,6 +12,10 @@ jobs:
     - uses: actions/checkout@v2
     - name: Setup .NET Core
       uses: actions/setup-dotnet@v4
+    - name: Tool restore
+      run: dotnet tool restore
+    - name: Format Check
+      run: dotnet fantomas . --check || echo "The code was not formatted, run `dotnet fantomas .` to format all code."
     - name: Restore
       run: dotnet restore
     - name: Run Build

Directory.Build.props

@@ -6,6 +6,11 @@
         <PackageTags>version;changelog;keepachangelog</PackageTags>
         <GeneratePathProperty>true</GeneratePathProperty>
         <PackageIcon>ionide.png</PackageIcon>
+        <NoWarn>$(NoWarn);3186,0042</NoWarn><!-- circumvent an error with the fake dependencymanager for paket: https://github.com/dotnet/fsharp/issues/8678 -->
+        <NoWarn>$(NoWarn);NU1902</NoWarn><!-- NU1902 - package vulnerability detected -->
+        <WarnOn>$(WarnOn);1182</WarnOn> <!-- Unused variables,https://learn.microsoft.com/en-us/dotnet/fsharp/language-reference/compiler-options#opt-in-warnings -->
+        <WarnOn>$(WarnOn);3390</WarnOn><!-- Malformed XML doc comments -->
+        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
     <ItemGroup>
         <PackageReference Include="Dotnet.ReproducibleBuilds" Version="1.1.1" PrivateAssets="All" />

src/Ionide.KeepAChangelog.Tasks/Library.fs

@@ -24,8 +24,10 @@ module Util =
         item.SetMetadata("Removed", data.Removed)
         item.SetMetadata("Fixed", data.Fixed)
         item.SetMetadata("Security", data.Security)
-        for (KeyValue(heading, lines)) in data.Custom do
+
+        for KeyValue(heading, lines) in data.Custom do
             item.SetMetadata(heading, lines)
+
         item
 
 type ParseChangelogs() =
@@ -41,7 +43,7 @@ type ParseChangelogs() =
     member val CurrentReleaseChangelog: ITaskItem = null with get, set
 
     [<Output>]
-    member val AllReleasedChangelogs: ITaskItem [] = null with get, set
+    member val AllReleasedChangelogs: ITaskItem array = null with get, set
 
     [<Output>]
     member val LatestReleaseNotes: string = null with get, set
@@ -58,9 +60,8 @@ type ParseChangelogs() =
                 changelogs.Unreleased
                 |> Option.iter (fun unreleased ->
                     this.UnreleasedChangelog <-
-                        TaskItem()
-                        |> Util.mapChangelogData unreleased
-                        |> Util.mapUnreleasedInfo)
+                        TaskItem() |> Util.mapChangelogData unreleased |> Util.mapUnreleasedInfo
+                )
 
                 let sortedReleases =
                     // have to use LINQ here because List.sortBy* require IComparable, which
@@ -72,7 +73,10 @@ type ParseChangelogs() =
                     |> Seq.map (fun (version, date, data) ->
                         TaskItem()
                         |> Util.mapReleaseInfo version date
-                        |> fun d -> match data with Some data -> Util.mapChangelogData data d | None -> d
+                        |> fun d ->
+                            match data with
+                            | Some data -> Util.mapChangelogData data d
+                            | None -> d
                     )
                     |> Seq.toArray
 
@@ -81,14 +85,12 @@ type ParseChangelogs() =
 
                 sortedReleases
                 |> Seq.tryHead
-                |> Option.iter (fun (version, date, data) ->
-                    data
-                    |> Option.iter (fun data ->
-                        this.LatestReleaseNotes <- data.ToMarkdown())
-                    )
+                |> Option.iter (fun (_version, _date, data) ->
+                    data |> Option.iter (fun data -> this.LatestReleaseNotes <- data.ToMarkdown())
+                )
 
                 true
-            | Error (formatted, msg) ->
+            | Error(formatted, msg) ->
 
                 this.Log.LogError(
                     $"Error parsing Changelog at {file.FullName}. The error occurred at {msg.Position}.{System.Environment.NewLine}{formatted}"