Remove set check for certain variable attributes due to sorting issues

ioos · Sep 16, 2024 · 9c1a8ce · 9c1a8ce
1 parent ee198c5
commit 9c1a8ce
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/compliance_checker/cf/cf_1_6.py b/compliance_checker/cf/cf_1_6.py
@@ -116,17 +116,13 @@ def check_child_attr_data_types(self, ds):
         """
 
         ctx = TestCtx(BaseCheck.MEDIUM, self.section_titles["2.5"])
-        special_attrs = {
-            "actual_range",
-            "valid_min",
-            "valid_max",
-            "valid_range",
-            "_FillValue",
-        }
+        special_attrs = ("actual_range", "valid_min", "valid_max",
+                         "valid_range", "_FillValue")
 
         for _var_name, var in ds.variables.items():
-            for att_name in special_attrs.intersection(var.ncattrs()):
-                self._parent_var_attr_type_check(att_name, var, ctx)
+            for att_name in special_attrs:
+                if att_name in var.ncattrs():
+                    self._parent_var_attr_type_check(att_name, var, ctx)
         return ctx.to_result()
 
     # TODO: consider renaming to avoid confusion with non-underscore