Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assert statement #1083

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented May 23, 2024

Asserts are dropped when using optimizations or compilers. They should be used only in tests, not in code. For more info see https://docs.astral.sh/ruff/rules/assert/

@ocefpaf ocefpaf force-pushed the remove_assert_statement branch from b354075 to b3f1891 Compare May 23, 2024 16:02
@ocefpaf ocefpaf requested a review from benjwadams May 23, 2024 16:06
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.68%. Comparing base (0a84ef6) to head (b3f1891).
Report is 1 commits behind head on develop.

Files Patch % Lines
compliance_checker/base.py 0.00% 1 Missing and 1 partial ⚠️
compliance_checker/suite.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1083      +/-   ##
===========================================
- Coverage    81.75%   81.68%   -0.07%     
===========================================
  Files           25       25              
  Lines         5224     5226       +2     
  Branches      1253     1255       +2     
===========================================
- Hits          4271     4269       -2     
- Misses         644      646       +2     
- Partials       309      311       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjwadams benjwadams merged commit 4b68576 into ioos:develop May 23, 2024
25 of 28 checks passed
@ocefpaf ocefpaf deleted the remove_assert_statement branch May 23, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants