Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pint instead of cf_units #1094

Closed
wants to merge 1 commit into from

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jun 20, 2024

There is still a long road ahead but we can probably ditch the heavy udunits2 dependency if this works.

xref.: Ouranosinc/xclim#1788

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 69.38776% with 15 lines in your changes missing coverage. Please review.

Project coverage is 81.53%. Comparing base (ae023d1) to head (a516db0).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
compliance_checker/units.py 61.53% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1094      +/-   ##
===========================================
- Coverage    81.98%   81.53%   -0.46%     
===========================================
  Files           25       26       +1     
  Lines         5224     5263      +39     
  Branches      1257     1259       +2     
===========================================
+ Hits          4283     4291       +8     
- Misses         633      657      +24     
- Partials       308      315       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ocefpaf ocefpaf force-pushed the pint_instead_cf_units branch 2 times, most recently from f276028 to bcd94b2 Compare June 20, 2024 16:17
@ocefpaf ocefpaf force-pushed the pint_instead_cf_units branch 2 times, most recently from 4c2a794 to 99a488e Compare June 20, 2024 17:55
@ocefpaf ocefpaf force-pushed the pint_instead_cf_units branch from 99a488e to 3cdff68 Compare August 15, 2024 18:56
@ocefpaf ocefpaf mentioned this pull request Aug 22, 2024
@ocefpaf ocefpaf force-pushed the pint_instead_cf_units branch from 3cdff68 to f4737d6 Compare August 29, 2024 18:05
@ocefpaf ocefpaf force-pushed the pint_instead_cf_units branch from f4737d6 to a516db0 Compare October 4, 2024 17:00
@ocefpaf ocefpaf mentioned this pull request Nov 5, 2024
2 tasks
@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 12, 2024

Closing this in favor of #1118

@ocefpaf ocefpaf closed this Nov 12, 2024
@ocefpaf ocefpaf deleted the pint_instead_cf_units branch November 12, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant