Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support restricted address type #1363

Merged
merged 9 commits into from
Mar 29, 2024

Conversation

msarcev
Copy link
Collaborator

@msarcev msarcev commented Mar 27, 2024

Description of change

Closes #1359

Needs iotaledger/iota-sdk#2206

Type of change

  • Enhancement (a non-breaking change which adds functionality)

@msarcev msarcev linked an issue Mar 27, 2024 that may be closed by this pull request
@msarcev msarcev marked this pull request as ready for review March 28, 2024 11:12
@brancoder brancoder self-requested a review March 29, 2024 10:12
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look to me like we are not displaying Restricted address capabilities anywhere in the app. Do we need them?
https://github.com/iotaledger/explorer/pull/1363/files#diff-0a3da7ec77ff3c7e54c59d56c9b181010f8908a29c12852028f331f1931c6510R55

Maybe if we were to show a restricted address page and display it there, but currently restricted address resolves to the inner address.
@begonaalvarezd wdyt?

Disregard the comment as it was caused by the build issue

@begonaalvarezd
Copy link
Member

Look to me like we are not displaying Restricted address capabilities anywhere in the app. Do we need them? https://github.com/iotaledger/explorer/pull/1363/files#diff-0a3da7ec77ff3c7e54c59d56c9b181010f8908a29c12852028f331f1931c6510R55

Maybe if we were to show a restricted address page and display it there, but currently restricted address resolves to the inner address. @begonaalvarezd wdyt?

discussed over slack, all clear now, just a rebuild was needed. This PR can be testned using the faucet address

@begonaalvarezd begonaalvarezd merged commit 52588c4 into dev Mar 29, 2024
4 of 6 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/support-restricted-addresses branch March 29, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add restricted address type support
3 participants