Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cleanup QR #7231

Merged
merged 9 commits into from
Aug 19, 2023
Merged

feat: cleanup QR #7231

merged 9 commits into from
Aug 19, 2023

Conversation

evavirseda
Copy link
Collaborator

Summary

Closes #7227

Changelog

- Cleanup QR

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@marc2332 marc2332 self-requested a review July 17, 2023 14:25
VmMad
VmMad requested changes Jul 17, 2023
View reviewed changes
packages/shared/components/QR.svelte Outdated Show resolved Hide resolved
packages/shared/components/QR.svelte Show resolved Hide resolved
@evavirseda evavirseda requested a review from VmMad July 17, 2023 15:04
VmMad
VmMad approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks purrrfect 😺

begonaalvarezd
begonaalvarezd requested changes Aug 1, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the QR is not centered anymore in the container box, the symetry is lost 🙏🏼
image

begonaalvarezd
begonaalvarezd approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@begonaalvarezd begonaalvarezd merged commit f8df16f into develop Aug 19, 2023
4 checks passed
@begonaalvarezd begonaalvarezd deleted the refactor/cleanup-qr branch August 19, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

@VmMad VmMad VmMad approved these changes

@marc2332 marc2332 marc2332 approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Cleanup QR
5 participants
@evavirseda @begonaalvarezd @marc2332 @VmMad @cpl121