Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add error when cannot allotment #8527

Merged
merged 2 commits into from
May 17, 2024

Conversation

evavirseda
Copy link
Collaborator

Summary

Closes #8526
...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda evavirseda requested a review from cpl121 May 13, 2024 16:50
@marc2332 marc2332 self-requested a review May 14, 2024 07:19
@marc2332 marc2332 linked an issue May 14, 2024 that may be closed by this pull request
@evavirseda evavirseda requested a review from cpl121 May 14, 2024 15:35
@begonaalvarezd begonaalvarezd merged commit 5104d5e into canary May 17, 2024
4 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/add-error-when-cannot-allotment branch May 17, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: there is no error when you cannot make allotment
3 participants