Add sql module #647
Merged
Add sql module #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muXxer
force-pushed
the
feat/add-sql-module-from-indexer
branch
from
baaab35
to
32ab137
Compare
muXxer
force-pushed
the
feat/add-sql-module-from-indexer
branch
3 times, most recently
from
8ac3907
to
4588d34
Compare
alexsporn
reviewed
Feb 23, 2024
db/engine.go
Outdated
| // no need to create or access a "database info file" in case of mapdb (in-memory) | ||
| // TODO: add an interface with a flag that indicates if the database needs the file system or not. | ||
| case EngineMapDB, EnginePostgreSQL: | ||
| // no need to create or access a "database info file" in case of mapdb (in-memory) or postgres (external database) | ||
| return EngineMapDB, nil |
There was a problem hiding this comment.
this return is wrong if you pass EnginePostgreSQL
muXxer
force-pushed
the
feat/add-sql-module-from-indexer
branch
from
1458ada
to
81a1e28
Compare
alexsporn
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.