Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(2.0 nodejs) Add clearStrongholdPassword to SecretManager #1830

Merged
merged 3 commits into from
Jan 11, 2024
Merged

feat(2.0 nodejs) Add clearStrongholdPassword to SecretManager #1830

merged 3 commits into from
Jan 11, 2024

Conversation

marc2332
Copy link
Contributor

Depends on #1829

Description of change

Enables support for clearStrongholdPassword in Nodejs's SecretManager

Type of change

  • Enhancement

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@marc2332 marc2332 mentioned this pull request Jan 11, 2024
Merged
@thibault-martinez thibault-martinez merged commit 5ac148f into iotaledger:2.0 Jan 11, 2024
9 checks passed
@marc2332 marc2332 deleted the feat/2.0-nodejs-clearStrongholdPassword-secret-manager branch January 11, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc2332 @thibault-martinez @Thoralf-M