Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests from TIP #1842

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Add more tests from TIP #1842

merged 2 commits into from
Jan 16, 2024

Conversation

DaughterOfMars
Copy link

Description of change

Adds tests from iotaledger/tips@237e175

kwek20
kwek20 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@kwek20 kwek20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know its from tip, but do we want some ManaGenerationTests with error?

@DaughterOfMars
Copy link
Author

I know its from tip, but do we want some ManaGenerationTests with error?

Well, there's actually only one way it can fail, and we covered that.

@DaughterOfMars DaughterOfMars merged commit 333a509 into 2.0 Jan 16, 2024
36 checks passed
@DaughterOfMars DaughterOfMars deleted the chore/mana-tip-tests branch January 16, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@kwek20 kwek20 kwek20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaughterOfMars @kwek20 @thibault-martinez @Thoralf-M