-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native binding #784
Add native binding #784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this actually publish anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super well versed with those workflows.
I've tested it in a private repo and I made it build and create downloadable artifacts.
Where they should be published to or anything else, I don't know how you want that handled and figured you know it better than I do. :)
If you give me some instructions I might be able to complete the workflow on my own.
Can you target the 1.1 branch please 🙏🏻 |
This would be useful for the c# binding. Hope it gets merged soon thanks |
344cfac
to
59943ad
Compare
59943ad
to
13ede60
Compare
@wireless90 Happy to see C# being used! @thibault-martinez Rebased with 1.1, Go tests currently running locally. Will test it with wasp-cli as well and give you feedback afterwords. |
Will be reopened in https://github.com/iotaledger/iota-sdk-native-bindings |
Description of change
Adds a new binding that can be compiled into a common shared library.
It can be referenced by other languages such as Go/C/C#/etc.
It exports the following functions:
C/C++ example headers were generated and are to be found at
bindings/native/headers
.A Go library example can be found here
The Go library is primarily used for the secret managers, but a basic Wallet implementation exists as well.
A readme was added in
bindings/native/README.md
to explain string/error handling, but it's not a complete guide.A CI workflow was added to build the library for linux, mac and windows. A trigger workflow does not exist yet.
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Tests were written in Go and can be found here