Skip to content

Improvements

Improvements #28

Triggered via pull request December 5, 2023 11:31
Status Failure
Total duration 30s
Artifacts

clippy.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 errors
constants have by default a `'static` lifetime: src/hasher.rs#L10
error: constants have by default a `'static` lifetime --> src/hasher.rs:10:26 | 10 | pub const SHA_ALG_NAME: &'static str = "sha-256"; | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes = note: `-D clippy::redundant-static-lifetimes` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::redundant_static_lifetimes)]`
passing a unit value to a function: src/encoder.rs#L323
error: passing a unit value to a function --> src/encoder.rs:323:7 | 323 | Ok(self.salt_size = salt_size) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg = note: `-D clippy::unit-arg` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::unit_arg)]` help: move the expression in front of the call and replace it with the unit literal `()` | 323 ~ self.salt_size = salt_size; 324 + Ok(()) |
clippy
Clippy had exited with the 101 exit code