Fix wasp-cli request sending #3522
Merged
+79
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessaya
approved these changes
Jan 15, 2025
| @@ -47,6 +48,7 @@ type PostRequestParams struct { | |||
| Allowance *isc.Assets | |||
| gasBudget uint64 | |||
| AutoAdjustStorageDeposit bool | |||
| OnlyUnlockedOutputs bool | |||
There was a problem hiding this comment.
Honestly if you are sending a request it doesn't make much sense to use locked outputs anyway... is the flag really needed?
There was a problem hiding this comment.
Yes because its needed by PostRequest functions. The OutputMap function is so interwoven that we need a flag before that. Its also used to pull balances and other information, where timelocked objects might be relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Updates the CLI to ignore timelocked outputs only when sending (requests)