crosschain calls #241
Open
crosschain calls #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CoderZhi
commented
Mar 14, 2024
CoderZhi
commented
- Add payload to cashier
- Call receivers in validator with payload
guo
reviewed
Mar 15, 2024
| @@ -0,0 +1,135 @@ | |||
| pragma solidity <6.0 >=0.4.24; | |||
There was a problem hiding this comment.
is this based on contracts/iotube/TransferValidator.sol? Why not contracts/iotube/TransferValidatorV2.sol instead?
ququzone
reviewed
Mar 15, 2024
| uint256 fee = msg.value; | ||
| if (_token == address(0)) { | ||
| require(msg.value >= _amount, "insufficient msg.value"); | ||
| fee = msg.value - _amount; |
There was a problem hiding this comment.
should check decimal overflow or use solidity 0.8 above
ququzone
reviewed
Mar 15, 2024
| } | ||
| witnesses[i] = witness; | ||
| } | ||
| require(numOfSignatures * 3 > witnessList.numOfActive() * 2, "insufficient witnesses"); |
There was a problem hiding this comment.
Move L58 to above of L49 can be more efficiently when insufficient witnesses occur
Liuhaai
reviewed
Mar 15, 2024
| for (uint256 it = 0; it < tokenLists.length; it++) { | ||
| if (tokenLists[it].isAllowed(tokenAddr)) { | ||
| uint256 numOfSignatures = signatures.length / 65; | ||
| address[] memory witnesses = new address[](numOfSignatures); |
There was a problem hiding this comment.
more readable to keep inside extractWitnesses()
Liuhaai
reviewed
Mar 15, 2024
|
|
||
| function depositTo(address _token, address _to, uint256 _amount, bytes calldata _payload) public whenNotPaused payable { | ||
| require(_to != address(0), "invalid destination"); | ||
| // require(_payload.length == 0 || contractDestinations[_to], "invalid destination with payload"); |
There was a problem hiding this comment.
how is contractDestinations used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.