introduce Hub as receivers #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liuhaai
reviewed
Jan 16, 2025
| } | ||
| require(_token.approve(address(r), _amount), "EthereumHub: approve router failed"); | ||
| amounts = r.swapTokensForExactETH(fee, _amount, path, address(this), block.timestamp + 10); | ||
| _amount = _amount - amounts[0]; |
There was a problem hiding this comment.
is this needed?
require(_amount>=amounts[0], "");
_amount = _amount - amounts[0];
Liuhaai
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if deposit fee of cashier is not 0
if the token amount to transfer is insufficient to pay the deposit fee, transfer token to
senderand returnelse swap in uniswap and call the cashier with the remaining token
payloadis a combination ofrecipient+second layer payload