Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of Addresses we should show iovnames/starnames/blockchain addresses #1057

Closed
annatorok opened this issue Mar 9, 2020 · 6 comments · Fixed by #1117
Closed

Instead of Addresses we should show iovnames/starnames/blockchain addresses #1057

annatorok opened this issue Mar 9, 2020 · 6 comments · Fixed by #1117

Comments

@annatorok
Copy link

annatorok commented Mar 9, 2020

Part of #1081.

Right now, in the menu, we have "Addresses".

Under this, we have 2 submenus: "Your iovnames" and "Your blockchain addresses". Later on, we will have "Your starnames" as well.

Instead of putting these in the submenu, we should put them in the menu.
"Your blockchain addresses" should be renamed to "Addresses"

@abefernan
Copy link
Contributor

Since the current plan involves extracting "Your iovnames" & "Your starnames" functionality to a separate application in a separate repo, the only remaining subtab of the "Addresses" tab would be "Your blockchain addresses".

Since it won't make sense to have a tab with a single subtab, it should be removed, and I personally believe the name "Addresses" is better than "Your blockchain addresses", because they won't be confused with iovnames or starnames.

@annatorok
Copy link
Author

@abefernan agreed, Addresses makes more sense.

@albertandrejev
Copy link
Contributor

So, should this issue to be implemented? @annatorok

@abefernan
Copy link
Contributor

@albertandrejev @annatorok I would not implement this until the extraction of names functionality to another repo is completely finished

@abefernan
Copy link
Contributor

Since the current plan involves extracting "Your iovnames" & "Your starnames" functionality to a separate application in a separate repo, the only remaining subtab of the "Addresses" tab would be "Your blockchain addresses".

Since it won't make sense to have a tab with a single subtab, it should be removed, and I personally believe the name "Addresses" is better than "Your blockchain addresses", because they won't be confused with iovnames or starnames.

@albertandrejev @annatorok and we should implement the changes in this comment, not the ones in the description of the ticket.

@annatorok annatorok changed the title Instead of Addresses we should sho iovnames/starnames/blockchain addresses Instead of Addresses we should show iovnames/starnames/blockchain addresses Apr 3, 2020
@davepuchyr
Copy link
Contributor

This ticket is decoupled from #1081 and will be closed via #1113.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants