Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #1113 - Merge menu bars #1117

Merged
merged 9 commits into from
Apr 23, 2020
Merged

Conversation

abefernan
Copy link
Contributor

@abefernan abefernan commented Apr 23, 2020

Closes #1113.
Closes #1057.

It also hides the link that shows the list of associated names to a starname when no names are present (starname/manage route).

The tests from the new routes (iovnames and starnames) have been copied from the addresses route's old testing code.

Copy link
Contributor

@davepuchyr davepuchyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@abefernan abefernan merged commit 44b6679 into master Apr 23, 2020
@abefernan abefernan deleted the feature/#1113-merge-menu-bars branch April 23, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge menu bars Instead of Addresses we should show iovnames/starnames/blockchain addresses
2 participants