Layout for "Manage starnames/iovnames/names" views #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertandrejev
added
Frontend 😊
albertandrejev
force-pushed
the
feature/#1021-manage-names
branch
from
991be4e
to
ab0ce3b
Compare
abefernan
approved these changes
Mar 16, 2020
| import AccountManage from "./manage"; | ||
| import AccountRegister from "./register"; | ||
| import AccountUpdate from "./update"; | ||
|
|
There was a problem hiding this comment.
Maybe move AccountEntity type from "./register" here?
There was a problem hiding this comment.
Sorry, do not understand you.
There was a problem hiding this comment.
You have the subdirectories: manage, register, and update. All of them use the AccountEntity type and AccountProps interface from the register subdirectory. Since the three of them use them, it no longer makes sense to have those declared in register, they should be declared on the root, which is this file.
So between the imports and the export you can declare:
type AccountEntity = "iovname" | "starname" | "name";
interface AccountProps {
entity: AccountEntity;
}Add them to the export, and removed them from the register's index.tsx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1021.
Starname manage
Starname update
Name manage
Name update
Iovname manage
Iovname update
