ci: only build uncached derivations #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpc
reviewed
Oct 16, 2023
| #!/usr/bin/env bash | ||
| curSystem=$(nix eval --raw --impure --expr builtins.currentSystem) | ||
|
|
||
| nixEvalJobsArgs=() |
There was a problem hiding this comment.
question: Why does it have to be such a long and involved process to do such a popular and needed thing...
There was a problem hiding this comment.
If you find out let me know cuz I'm also curious!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Even when a derivation is cached,
nix buildwill still download it. I'm not 100% sure ifnix flake checkstill downloads cached derivations or not, but there's no harm in ensuring we never download cached derivations by usingnix-eval-jobsChecklist
docs/API.md(or general documentation) with changesCHANGELOG.md