Cannot set cargoExtraArgs in craneLib.cargoNextest (#675) #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `cargo nextest run` and `cargo llvm-cov` do not place any cargo options/flags right behind `cargo <HERE> ...`. All cargo related flags can be added to the `cargoNextestExtraArgs` attribute. [Issue ipetkov#675]
After altering `checkPhaseCargoCommand` to use one of two explicit command strings inside if/else blocks, it is no longer necessary to default `cmd` to an empty value when `withLlvmCov` is set to `true`.
|
I have made the decision to alter the creation of Since I'm still a noob with Nix, there might be benefits of using optional strings over if/else that I don't know of. Up for discussion, I guess. 😄 |
ipetkov
reviewed
Aug 6, 2024
|
You can ignore the |
ipetkov
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To resolve issue (#675) with the
cargoExtraArgsattribute incraneLib.cargoNextestbeing placed in betweencargo <HERE> nextestorcargo <HERE> llvm-cov nextestwhere there should be no options/flags.Cargo flags cannot be used in this context. Only
cargo nextest run/archiveflags, which contain all the flags fromcargo test(at least) are possible.Sources I have checked:
Checklist
docs/API.md(or general documentation) with changesCHANGELOG.md