Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NewClient): support https:// URLs #277

Merged
merged 2 commits into from
Jan 10, 2025
Merged

fix(NewClient): support https:// URLs #277

merged 2 commits into from
Jan 10, 2025

Conversation

lidel
Copy link
Member

@lidel lidel commented Jan 10, 2025

This is alternative way of fixing issue from #276

We don't hardcode any specific ports, but assume http:// (backward-compatible behavior) unless https:// is passed (then we keep it as-is).

ipfs/kubo#10659 will pass https:// if multiaddr ending with /https or /tls/http is passed via ipfs --api

We don't hardcode any specific ports, but assume `http://`
(backward-compatible behavior)  unless `https://` is passed (then we
keep it as-is).
this is backward-compatible fix, ok to just bump patch
Copy link

Suggested version: 0.14.1

Comparing to: v0.14.0 (diff)

Changes in configuration file(s):

diff --git a/go.mod b/go.mod
index 936b4a6..1b06924 100644
--- a/go.mod
+++ b/go.mod
@@ -9,7 +9,7 @@ require (
 	github.com/ipfs/go-log v1.0.5
 	github.com/rs/cors v1.11.1
 	github.com/texttheater/golang-levenshtein v1.0.1
-	golang.org/x/term v0.24.0
+	golang.org/x/term v0.25.0
 )
 
 require (

gorelease says:

gorelease: go: loading module retractions for go.opentelemetry.io/otel/exporters/otlp/[email protected]: module go.opentelemetry.io/otel/exporters/otlp/[email protected] requires go >= 1.22.7 (running go 1.22.0)
go: loading module retractions for go.opentelemetry.io/otel/exporters/otlp/otlptrace/[email protected]: module go.opentelemetry.io/otel/exporters/otlp/otlptrace/[email protected] requires go >= 1.22.7 (running go 1.22.0)
go: loading module retractions for go.opentelemetry.io/otel/exporters/otlp/otlptrace/[email protected]: module go.opentelemetry.io/otel/exporters/otlp/otlptrace/[email protected] requires go >= 1.22.7 (running go 1.22.0)
go: loading module retractions for honnef.co/go/[email protected]: module honnef.co/go/[email protected] requires go >= 1.22.1 (running go 1.22.0)

gocompat says:

HEAD is now at 7f9933b chore: release v0.14.0 (#269)
Previous HEAD position was 7f9933b chore: release v0.14.0 (#269)
Switched to branch 'master'
Your branch is up to date with 'origin/master'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to master. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@lidel lidel merged commit a32ea33 into master Jan 10, 2025
12 checks passed
@lidel lidel deleted the pr-276 branch January 10, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant