Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/Replace Embedded Node Type #1220

Closed
whizzzkid opened this issue Jun 17, 2023 · 4 comments
Closed

Remove/Replace Embedded Node Type #1220

whizzzkid opened this issue Jun 17, 2023 · 4 comments
Assignees
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers P2 Medium: Good to have, but can wait until someone steps up

Comments

@whizzzkid
Copy link
Contributor

Embedded node types will not be supported in Mv3, Helia in service-worker context can provide an alternative, however service-workers in chrome-extension mv3 has its own limitations: w3c/webextensions#72 The biggest ones are the lack of webRTC streams and webSockets.

More work will be needed to explore this.

@whizzzkid whizzzkid added the need/triage Needs initial labeling and prioritization label Jun 17, 2023
@BigLep
Copy link
Contributor

BigLep commented Jun 19, 2023

I like the idea of replacing, but that's a bigger endeavor. Do we instead just break this into two steps:

  1. Remove embedded/js-ipfs
  2. Add something better back in

Basically, if it's not a lot of work to remove, lets make our maintenance burden lighter by get rid of code that isn't tested and isn't supported anymore.

@whizzzkid
Copy link
Contributor Author

@BigLep agreed, I think this can be removed only for chrome mv3, as this would still work in firefox. However, just to be consistent, this can be removed everywhere. Should the UI also reflect this (by removing the entire section to configure this) I think we can leave that as-is till we have more node types.

Tasks:

  • Remove js-ipfs
  • Remove custom icons for JS.
  • Remove references to embedded node-type.
  • Remove UI options. (optional)

@whizzzkid whizzzkid added P2 Medium: Good to have, but can wait until someone steps up exp/beginner Can be confidently tackled by newcomers and removed need/triage Needs initial labeling and prioritization labels Jun 22, 2023
@whizzzkid whizzzkid self-assigned this Jun 22, 2023
@whizzzkid whizzzkid added the effort/hours Estimated to take one or several hours label Jun 22, 2023
@BigLep
Copy link
Contributor

BigLep commented Jun 22, 2023

@whizzzkid : I think we should remove it everywhere. We're not able to support it in Firefox if users have issues. I assume it also cleans up the code to to remove it everywhere. Lets definitely remove it from docs and UI as well. It's not clear at this point if/when we'll replace it with Helia, so I think better to be accurate to where we are.

@whizzzkid
Copy link
Contributor Author

done in #1225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers P2 Medium: Good to have, but can wait until someone steps up
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants