refactor: replace upload with import terminology #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinfruit
commented
Dec 10, 2019
| @@ -29,7 +29,7 @@ None. We don’t collect your Personal Data, period. | |||
| We do not collect, rent, store or sell your Personal Data to anyone. However | |||
| because IPFS Companion is a web extension that provides access to the real-time, | |||
| peer-to-peer IPFS Network (which is a public platform for which anyone may join | |||
| and participate) the data that you add or upload to the IPFS Network using IPFS | |||
There was a problem hiding this comment.
Wanted to call this out because upload in the context of the privacy policy may have implications I don't know about, and didn't want it to be merged silently.
There was a problem hiding this comment.
I really appreciate this, thank you!
Two asks:
- In this case it makes more sense to remove
addand just keepimport(it covers more ground) - Also, there is a date labeled
Last Updateat the top of the file, please bump it to current date (helps when we copy & paste it to addon stores)
lidel
requested changes
Dec 10, 2019
| @@ -29,7 +29,7 @@ None. We don’t collect your Personal Data, period. | |||
| We do not collect, rent, store or sell your Personal Data to anyone. However | |||
| because IPFS Companion is a web extension that provides access to the real-time, | |||
| peer-to-peer IPFS Network (which is a public platform for which anyone may join | |||
| and participate) the data that you add or upload to the IPFS Network using IPFS | |||
There was a problem hiding this comment.
I really appreciate this, thank you!
Two asks:
- In this case it makes more sense to remove
addand just keepimport(it covers more ground) - Also, there is a date labeled
Last Updateat the top of the file, please bump it to current date (helps when we copy & paste it to addon stores)
lidel
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on the changes made in #810. This simple change replaces references to
uploadwithimport.closes #817