feat: disable integrations per website #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
feat/disable-integrations-on-page
branch
from
60eab90 to
4e8eec1
Compare
This change replaces per-site redirect toggle with one that disables ALL IPFS integrations: redirect, content scripts, and access to API via window.ipfs It also changes the order of menu items to prioritize actions related to a current tab.
lidel
force-pushed
the
feat/disable-integrations-on-page
branch
from
4e8eec1 to
12440ff
Compare
lidel
commented
Dec 11, 2019
| "message": "Redirect on $1", | ||
| "description": "A menu item in Browser Action pop-up (panel_activeTabSiteRedirectToggle)" | ||
| "panel_activeTabSiteIntegrationsToggle": { | ||
| "message": "Enable on $1", |
There was a problem hiding this comment.
Not sure if Enable on <hostname> is the best label for this menu item, but it is short and simple.
Let me know if there is a better one.
lidel
commented
Dec 11, 2019
| @@ -280,7 +280,7 @@ | |||
| "description": "An option description on the Preferences screen (option_useCustomGateway_description)" | |||
| }, | |||
| "option_dnslinkRedirect_title": { | |||
| "message": "Force page load from custom gateway", | |||
| "message": "Load websites from Custom Gateway", | |||
There was a problem hiding this comment.
Softening language because we restored the old behavior in #831
(and matching capitalization from other places)
hugomrdias
approved these changes
Dec 12, 2019
|
I'm merging this to ship in beta before v2.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces per-site redirect toggle with one that disables ALL IPFS integrations: redirect to local gateway, injection of content scripts, DOM changes, and access to API via window.ipfs
closes #828, closes #820, cc #710, #689, #589
Motivation
Instead of disabling redirect per website, users should be able to disable all integrations that change page, mutate DOM etc.
Tasks
window.ipfs(
noRedirectHostnames→noIntegrationsHostnames)Preview
User can disable IPFS per host, including DNSLink websites:
If website is powered by DNSLink, the toggle will disable redirect, but there will be an option to open it manually:
We redirect DNSLink websites by default, but this behavior can be tweaked via Preferences: