-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: welcome page #1571
feat: welcome page #1571
Conversation
@lidel and @rafaelramalho19 -- I believe this is ready for your review, thanks for all your help in the meantime 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big 👍 for effort to make the connectivity troubleshooting so much more intuitive!
Below answers to your questions and some nits at the end.
Does anything need to be modified as a result of #1563 ?
I don't believe there are any conflicts, but you may rebase on top of latest master just to be sure.
[..] will Transifex take care of reconciling differences between locales/en files to remove outdated i18n text, or does anything else need to be done first?
Transifex will automatically update itself within 24h after this PR is merged, no need for additional steps. The next time we pull translations before the release, locale files for languages other than en
will get updated. In the meantime, en
version will be used as a fallback.
I've found some UX nits when transitioning "online" → "offline" (eg. when I shut down my go-ipfs node):
-
Connection error is displayed, and the graphs get faded out, but they keep showing the last bandwidth values:
I'd expect "offline" state to set them to zeroes.
-
Files, Explore, Peers in navbar are not being correctly disabled. I can go to each and there is either error or an outdated cached data that does not update. If I refresh page (F5) then those screens are replaced with connection error on status page.
-
The flow that starts with clicking on → Expanded Status → API multiaddr Edit → Settings → API multiaddr input is really nice. It encourages user to intuitively discover things.
The problem: when in offline status, clicking on the does nothing. It can't expand node info, because API is down and that block is hidden. Perhaps the fix is to skip expand step and immediately open the Settings and scroll to API address input?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarification: nits I described were already present in old version, so ok to merge this and tackle them separately
Sounds good; see #1575 for node shutoff experience tweaks. I'll rebase against latest master and merge if all well. Thanks! |
9ee7a2a
to
b813ad6
Compare
In this PR
Make the "welcome" page at #/welcome available by clicking the IPFS cube logo in the navbar, and adjust details for continuity.
Done
WelcomeInfo
box as it didn't really make sense there and added clutterinfo-boxes/welcome-info
and add its contents toWelcomePage.js
; movewelcomeInfo
i18n text intowelcome.json
WelcomeInfo
andAboutIpfs
content for clarityWelcomeInfo
with shorter, friendly messaging<ApiAddressForm>
box, since it's rarely relevant here (but add to settings page to account for edge cases; see below)<Shell>
header, to streamline and avoid showing user commands they don't need (thanks @rafaelramalho19!)<ApiAddressForm>
into the troubleshooting guidance (thanks @rafaelramalho19!)<ApiAddressForm>
section of settings page (thanks @rafaelramalho19!)<ApiAddressForm>
above "IPFS Config" box, to account for users who are already connected but want to connect to a different IPFS APIOpen questions
locales/en
files to remove outdated i18n text, or does anything else need to be done first?Extra note
These changes will require updating screenshots across a number of locations in our ecosystem. I'll take care of that in separate PR(s) once we know when we'd ship a release.
Screenshots
Welcome page, connected
Welcome page, disconnected
Files page when no files
Status page upon connection interruption
Closes #1463. Also refs #1406 about adding a link to Awesome IPFS somewhere in welcome content.