-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add by path #708
feat: add by path #708
Conversation
Nice! some minor issues when trying it out:
See: http://tachyons.io/docs/themes/skins-pseudo I just copied and pasted a path from https://archives.ipfs.io/ and it told me it was not valid... turned out there was some rogue whitespace at the front of what I had pasted, but I couldn't see it as the input is narrow and paths are loooooong... can we make the input wider and the font smaller, and trim whitespace on paste pls? More generally we need to focus on robustness and showing good loading info as the next priority, as the files section is working well, but the UI keeps feeling like it is stuck for me, when I try and preview large files (perhaps we should open large files in a browser tab rather than in line) and large dir listing can take a really long time to load and display. |
7eb9fdc
to
830a42c
Compare
Done 😄
Wouldn't it look odd side by side with other modals even if it's just on the input?
Yes, we can.
Yes, it's the next step. Already mentioned that on #704 (visual feedback). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Dropdown should close when you select the by path
option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool 👍
Add files by IPFS path.
On this PR, I also created a generic
TextInputModal
which was used for the modal above and for rename modal.