Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditions changed according to the requirement #454

Closed

Conversation

07Vaishnavi-Singh
Copy link

@07Vaishnavi-Singh 07Vaishnavi-Singh commented Oct 28, 2024

Changes

  1. Optmized conditions according to - https://nodejs.org/api/buffer.html#static-method-bufferisbufferobj

  2. Only to return true if the obj is string or is not an object or is a null

Related to #453

@07Vaishnavi-Singh 07Vaishnavi-Singh requested a review from a team as a code owner October 28, 2024 20:13
Copy link

welcome bot commented Oct 28, 2024

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@07Vaishnavi-Singh 07Vaishnavi-Singh marked this pull request as draft October 28, 2024 20:14
@07Vaishnavi-Singh 07Vaishnavi-Singh marked this pull request as ready for review October 28, 2024 20:21
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want to add any submodules. We also do not want to add a dependency on ipfs-webui in this repo

@SgtPooki SgtPooki marked this pull request as draft October 29, 2024 16:15
@07Vaishnavi-Singh
Copy link
Author

07Vaishnavi-Singh commented Oct 29, 2024

@SgtPooki Ahh!!!! my bad. I think the submodule got added by mistake in the previous commit. I have changed the condition to be true if

  1. obj is null
  2. obj is not an object at all
  3. If obj is an object then it has to be a string
    and final
  4. if it is a string then isBuffer(obj)-> false then it should be a string

Let me know if I got this right

@07Vaishnavi-Singh 07Vaishnavi-Singh marked this pull request as ready for review October 29, 2024 18:15
@SgtPooki
Copy link
Member

SgtPooki commented Nov 1, 2024

@07Vaishnavi-Singh Thanks so much for contributing. I put together more of what I was looking for in #460, plus a fix for another bug I found.

@SgtPooki SgtPooki closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants