Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

chore: update dag-pb dep #3070

Merged
merged 3 commits into from
Jul 27, 2020
Merged

chore: update dag-pb dep #3070

merged 3 commits into from
Jul 27, 2020

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Jun 5, 2020

This is an attempt to asses if changes from ipld/js-ipld-dag-pb#184 can be integrated into js-ipfs without breaking things, which in turn would address some problems I've run into #3022 (comment)

@Gozala Gozala marked this pull request as draft June 10, 2020 20:48
@Gozala Gozala requested a review from hugomrdias June 15, 2020 22:14
@Gozala Gozala marked this pull request as ready for review June 15, 2020 22:14
@Gozala Gozala changed the title WIP: add pure data model interop for dag-pb Add pure data model interop for dag-pb Jun 15, 2020
@Gozala
Copy link
Contributor Author

Gozala commented Jun 15, 2020

This was mostly to verify that proposed changes to dag-pb were not introducing regressions. However since dag-pb was released it would be good to land this to avoid divering #3081 too much.

@Gozala Gozala marked this pull request as draft June 16, 2020 00:52
@Gozala Gozala force-pushed the pure-data-dag-pb branch from 0f4cd13 to 3c0fca1 Compare June 16, 2020 00:54
@Gozala
Copy link
Contributor Author

Gozala commented Jun 16, 2020

Never mind, I this mixed with dag-cbor instead.

Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs the GH URLs removing before merging.

@Gozala Gozala force-pushed the pure-data-dag-pb branch from c8628d5 to cb764c6 Compare July 24, 2020 20:38
@Gozala Gozala marked this pull request as ready for review July 24, 2020 20:39
@Gozala Gozala requested a review from achingbrain July 24, 2020 21:44
@achingbrain achingbrain changed the title Add pure data model interop for dag-pb chore: update dag-pb dep Jul 27, 2020
@achingbrain achingbrain merged commit 09735ca into ipfs:master Jul 27, 2020
SgtPooki referenced this pull request in ipfs/js-kubo-rpc-client Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants