This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gozala
changed the title
WIP: add pure data model interop for dag-pb
Add pure data model interop for dag-pb
Jun 15, 2020
This was mostly to verify that proposed changes to dag-pb were not introducing regressions. However since dag-pb was released it would be good to land this to avoid divering #3081 too much. |
Never mind, I this mixed with dag-cbor instead. |
achingbrain
reviewed
Jul 24, 2020
achingbrain
suggested changes
Jul 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, needs the GH URLs removing before merging.
6 tasks
achingbrain
approved these changes
Jul 27, 2020
achingbrain
changed the title
Add pure data model interop for dag-pb
chore: update dag-pb dep
Jul 27, 2020
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to asses if changes from ipld/js-ipld-dag-pb#184 can be integrated into js-ipfs without breaking things, which in turn would address some problems I've run into #3022 (comment)