This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: ipfs-http-client should lowercase key type when submitting to kubo #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I'm not sure what to do here since I'm getting TypeScript errors now. If I update the types to reflect what Kubo supports it'd be a major breaking change in the API. :/ Maybe we can relax the type to be |
|
Thank you so much for opening this PR and for your patience in getting it merged. js-ipfs is being deprecated in favor of Helia. You can #4336 and read the migration guide. Please swap out |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4272
Without this one cannot generate a new key in TypeScript with Kubo since the TypeScript types require uppercase key names.
Not sure if the types should be changed since I'm not sure if js-ipfs-core relies on the uppercase version.