Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add video e2e tests #529

Merged
merged 8 commits into from
Dec 12, 2024
Merged

test: add video e2e tests #529

merged 8 commits into from
Dec 12, 2024

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Dec 12, 2024

  • chore: update package-lock.json
  • fix: config UI is up to date with IDB
  • chore: apply self suggestions from code review
  • chore: fix build and lint
  • test: add video e2e tests

Title

test: add video e2e tests

Description

A test to help confirm improved performance for ipfs/helia-verified-fetch#163 and check for regressions with video rendering.

Notes & open questions

Running against main:

> npm i --save @helia/verified-fetch@latest && npm run test:chrome -- -g 'starts playing automatically' --repeat-each=10 --workers=1

# ...

Running 10 tests using 1 worker

  ✓  1 [chromium] › video.test.ts:23:3 › video › starts playing automatically (2.1s)
  ✓  2 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.9s)
  ✓  3 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.9s)
  ✓  4 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.8s)
  ✓  5 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.9s)
  ✓  6 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.9s)
  ✓  7 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.9s)
  ✓  8 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.9s)
  ✓  9 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.8s)
  ✓  10 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.9s)

  10 passed (44.0s)

Running with verified-fetch from ipfs/helia-verified-fetch#163

> npm i --save /Users/sgtpooki/code/work/protocol.ai/ipfs/helia-verified-fetch/packages/verified-fetch/helia-verified-fetch-2.3.0.tgz && npm run test:chrome -- -g 'starts playing automatically' --repeat-each=10 --workers=1

# ...

Running 10 tests using 1 worker

  ✓  1 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.9s)
  ✓  2 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.9s)
  ✓  3 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.8s)
  ✓  4 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.8s)
  ✓  5 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.9s)
  ✓  6 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.8s)
  ✓  7 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.8s)
  ✓  8 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.9s)
  ✓  9 [chromium] › video.test.ts:23:3 › video › starts playing automatically (2.0s)
  ✓  10 [chromium] › video.test.ts:23:3 › video › starts playing automatically (1.9s)

  10 passed (38.9s)

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@SgtPooki SgtPooki mentioned this pull request Dec 12, 2024
3 tasks
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

@SgtPooki SgtPooki merged commit d72a0a7 into main Dec 12, 2024
17 checks passed
@SgtPooki SgtPooki deleted the test/video-loading branch December 12, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant