Fix multiline case statement #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An Oozie case statement can be multiline and even with simple expression users often put the el expression on its own line. If not handled carrefully it leads to an invalid file. Indeed, the DOT language specifies that a double-quoted string "allows single logical lines to span multiple physical lines using the standard C convention of a backslash immediately preceding a newline character." Usually EL expressions are short enough to be merged as a single line. If required we can use a more sophisticated algorithm to decide if the lines should be joined or not.
Even if the DOT language specification says that the ID after (di)graph is optional, some tools like dotty crash if ID is ommited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oozie users usually write case statement as follows:
A such entry lead vizoozie to generate an invalid DOT file. This pull request fix this issue. I decided to join all the lines since I never saw a huge EL expression in a case statement.