dpvs-agent dump/launch services #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
you-looks-not-tasty
commented
Dec 26, 2023
you-looks-not-tasty
commented
- set query params 'snapshot' of API(/v2/vs) to dump the running service into cache file.
- resume running service with snapshot cache file by launch params 'init-mode=local'.
- new API(/v2/vs/${SERVICE-ID}/health) for dpvs-healthcheck.
…vice into cache file.
2. resume running service with snapshot cache file by launch params 'init-mode=local'
3. new API(/v2/vs/${SERVICE-ID}/health) for dpvs-healthcheck
ywc689
reviewed
Jan 2, 2024
Comment on lines
+93
to
+119
| // 4> bind laddr with vs (ipvsadm --add-laddr -z ${LADDR} -t ${VIPPORT} -F ${device}) | ||
| laddr := types.NewLocalAddrFront() | ||
| if err := laddr.ParseVipPortProto(vs.ID()); err != nil { | ||
| } | ||
| lds := make([]*types.LocalAddrDetail, len(laddrs.Items)) | ||
| for i, lip := range laddrs.Items { | ||
| lds[i] = types.NewLocalAddrDetail() | ||
| lds[i].SetAddr(lip.Addr) | ||
| lds[i].SetIfName(lip.Device) | ||
| } | ||
| laddr.Add(lds, cp, logger) | ||
| // 5> ip addr add ${VIP} dev ${KNIDEVICE(lo?)} | ||
| if err := device.NetlinkAddrAdd(service.Addr, announcePort.Switch, logger); err != nil { | ||
| logger.Error("add addr", service.Addr, "onto device failed") | ||
| errs = append(errs, err) | ||
| } | ||
| } | ||
| // 6> dpip addr add ${LADDR} dev ${device} | ||
| for _, lip := range laddrs.Items { | ||
| lipAddr := types.NewInetAddrDetail() | ||
| lipAddr.SetAddr(lip.Addr) | ||
| lipAddr.SetIfName(lip.Device) | ||
| lipAddr.SetFlags("sapool") | ||
| resultCode := lipAddr.Add(cp, logger) | ||
| logger.Info("Add addr to device done.", "Device", lip.Device, "Addr", lip.Addr, "result", resultCode.String()) | ||
| } | ||
|
|
There was a problem hiding this comment.
Were the following cases considered?
- The forwarding mode is not FNAT, such as DR, Tunnel.
- The local addresses for FNAT services aren't always the same.
- The virtual addresses aren't required announced on netlink device.
The above features may not support in this intial version, but at least should be handled properly to ensure the procedure is successful and all the services booting from local file are correct.
Comment on lines
+177
to
+183
| VsAnnouncePort: | ||
| type: object | ||
| properties: | ||
| switch: | ||
| type: string | ||
| dpvs: | ||
| type: string |
There was a problem hiding this comment.
A little hard to understand. Add some comments or use more expresive names?
| services := &models.VirtualServerList{Items: make([]*models.VirtualServerSpecExpand, len(snapshot.Services))} | ||
| i := 0 | ||
| for _, svc := range snapshot.Services { | ||
| services.Items[i] = svc |
Comment on lines
+119
to
+122
| if err := os.Rename(cacheFile, bakName); err != nil { | ||
| logger.Error(err.Error()) | ||
| return err | ||
| } |
There was a problem hiding this comment.
Should it consider the case where the chacheFile doesn't exist?
Comment on lines
+35
to
+38
| func ShareSnapshot() *types.NodeSnapshot { | ||
| initOnce.Do(setUp) | ||
| return shareSnapshot | ||
| } |
There was a problem hiding this comment.
Should multi-thread safety be considered for the global data shareSnapshot?
ywc689
approved these changes
Jan 12, 2024
ywc689
added
the
pr/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.