Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ProMPs and Kinematics functionalities #3

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

souljaboy764
Copy link

Implemented Probabilistic Movement Primitives, specifically the conditioning aspect along with a general kinematics base class to perform forward and inverse kinematics. This needs to be extended for specific robots, providing the corresponding forward model. The code is adapted from https://github.com/sebasutp/promp

TODO:

@souljaboy764
Copy link
Author

Need to test a bit more before this can be merged

@souljaboy764
Copy link
Author

Tested the ProMP and Kinematics codes and they are working now.
Need to add examples to show how to use them.

@souljaboy764 souljaboy764 reopened this Mar 27, 2020
@joe-campbell
Copy link
Contributor

Sorry for the late followup, somehow I missed when this was opened.

From your last comment, if you could add examples for how to use this so I could better understand the changes then that would be great! Something like a minimal tutorial script or such.

Committer: souljaboy764
@souljaboy764
Copy link
Author

I have added an example file at examples/promp_example.py and have also added a notebook about it as well.

@souljaboy764
Copy link
Author

I was having issues when importing the package in python3 due to the relative imports. I have changed the imports in the files to support python3 style syntax. I am now able to run the basic examples on python3.

@hbaradius
Copy link

We should add souljaboy to the list of contributers to the IntPrim library. Very cool stuff!

@joe-campbell
Copy link
Contributor

Thanks for the latest push! Apologies for the lack of activity on my end, I was caught up in some other work. I will look at this in some detail over the weekend try to merge it. By the way, I noticed there are some hard coded paths in this latest commit, e.g.,

with open('/home/corobi/playground/intprim_test/strike_mov.npz','rb') as f:

Can this be changed such that any path is able to be set as a parameter? Otherwise other people won't be able to run these tests without modifying the source code first.

@souljaboy764
Copy link
Author

Oh, I must have overlooked this.
I'll add the path to be given as a command line argument and add a comment on the usage.

@souljaboy764
Copy link
Author

@joe-campbell Any suggestions on how to do that for the python notebook version of the example? Or should I just include the strike_mov.npz file from https://github.com/sebasutp/promp which I've used for the examples?

@joe-campbell
Copy link
Contributor

Hmm, there's no license given in that other library so I would prefer not to include any other data files directly. How about if we just provide an instruction in the notebook to download it and unzip it to a relative path location that the notebook looks for?

The notebook won't run without that, but I think it's ok. And the locally compiled version which is pushed up to github will still show what it looks like when that file is present.

@souljaboy764
Copy link
Author

I updated the examples and the notebook as well. I had also changed some of the code to be python3 compatible in one of the previous commits. It works on my system but would need to be tested further before claiming it to be properly python3 compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants