Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #198

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Update dependencies #198

merged 4 commits into from
Sep 2, 2024

Conversation

jamescurtin
Copy link
Collaborator

@jamescurtin jamescurtin commented Sep 1, 2024

As part of drafting a different PR, I ran pip-compile and noticed that it resulted in some packages being upgraded.

  1. The first commit is the auto-generated change resulting from re-running pip-compile ./requirements.in.
  2. Upgrading Django resulted in the auto-generation of some login-related frontend code, which is committed in the second commit.
  3. One package, easy-thumbnails, had an incompatibility with Django 5.1 (documented here), which is resolved in the third commit by setting a minimum version for the package as well as explicitly setting the storage backend.

While I have confirmed that the app starts up successfully, I do not yet have a more robust testing strategy for making changes like this--in particular given that the Django upgrade was across a major version. I figured I'd start by proposing this change in the spirit of keeping dependences up-to-date--but if this seems risky given the current light test coverage, I can re-work this and just pin django<5 in requirements.in.

@iragm
Copy link
Owner

iragm commented Sep 1, 2024

Awesome work. I do not want to merge this one just yet, I am about to go out of town for a couple days and don't want to break things right before I leave. I will test stuff and merge it next week.

@iragm iragm merged commit 96571c2 into iragm:master Sep 2, 2024
2 checks passed
@jamescurtin jamescurtin deleted the update-dependencies branch September 3, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants