Add linting #201
Merged
Add linting #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes re-imports of 3rd party packages from other modules
This was an autogenerated commit.
|
You've made my week with all these fixes. Absolutely incredible work. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the default linter with two modifications:
iSortimport sorting is enabledE722is ignored for now based on this discussion. Once it's a better time to look into the right exceptions to catch, we can remove this ignore.Each commit that's tagged with a linter code was manually generated, as these issues were not auto-resolvable. The last commit contains all of the remaining fixes that
ruffwas able to make itself.