Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chathistory: Specify that REDACT in chathistory does not depend on event-playback #538

Merged
merged 2 commits into from
May 4, 2024

Conversation

progval
Copy link
Contributor

@progval progval commented Apr 9, 2024

As pointed out in #537

@jwheare
Copy link
Member

jwheare commented Apr 12, 2024

The list of "eithers" is a bit awkward with repeated bits. What about this instead?

When a message is redacted, [`chathistory`][] responses SHOULD either:

* Exclude it entirely
* After the redacted message, include a `REDACT` message in the response that doesn't count towards message limits. The redacted message's content and/or tags MAY be replaced with a placeholder.

The `draft/event-playback` capability is not required in order to include `REDACT` messages in `chathistory` responses.

@progval
Copy link
Contributor Author

progval commented Apr 12, 2024

Done, with a grammar fix

@jwheare jwheare merged commit c9ff1a8 into ircv3:master May 4, 2024
@progval progval deleted the event-playback branch December 26, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants