Update onnx package version minimum to 1.16.0. #17504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saienduri
approved these changes
May 28, 2024
gglangg
pushed a commit
to gglangg/iree
that referenced
this pull request
Jun 4, 2024
As discovered on iree-org#17476 (comment), this is needed to avoid an error running `iree-import-onnx` on certain test files: > onnx.onnx_cpp2py_export.checker.ValidationError: Your model ir_version 10 is higher than the checker's (9). If we care about supporting older onnx package versions, we could add some fallback code to `iree-import-onnx`. We may also want to update the version used in torch-mlir? https://github.com/llvm/torch-mlir/blob/e0a5adb1db38b0072c44b87570bc530eb3b324ad/setup.py#L264
gglangg
pushed a commit
to gglangg/iree
that referenced
this pull request
Jun 4, 2024
As discovered on iree-org#17476 (comment), this is needed to avoid an error running `iree-import-onnx` on certain test files: > onnx.onnx_cpp2py_export.checker.ValidationError: Your model ir_version 10 is higher than the checker's (9). If we care about supporting older onnx package versions, we could add some fallback code to `iree-import-onnx`. We may also want to update the version used in torch-mlir? https://github.com/llvm/torch-mlir/blob/e0a5adb1db38b0072c44b87570bc530eb3b324ad/setup.py#L264
bangtianliu
pushed a commit
to bangtianliu/iree
that referenced
this pull request
Jun 5, 2024
As discovered on iree-org#17476 (comment), this is needed to avoid an error running `iree-import-onnx` on certain test files: > onnx.onnx_cpp2py_export.checker.ValidationError: Your model ir_version 10 is higher than the checker's (9). If we care about supporting older onnx package versions, we could add some fallback code to `iree-import-onnx`. We may also want to update the version used in torch-mlir? https://github.com/llvm/torch-mlir/blob/e0a5adb1db38b0072c44b87570bc530eb3b324ad/setup.py#L264
LLITCHEV
pushed a commit
to LLITCHEV/iree
that referenced
this pull request
Jul 30, 2024
As discovered on iree-org#17476 (comment), this is needed to avoid an error running `iree-import-onnx` on certain test files: > onnx.onnx_cpp2py_export.checker.ValidationError: Your model ir_version 10 is higher than the checker's (9). If we care about supporting older onnx package versions, we could add some fallback code to `iree-import-onnx`. We may also want to update the version used in torch-mlir? https://github.com/llvm/torch-mlir/blob/e0a5adb1db38b0072c44b87570bc530eb3b324ad/setup.py#L264 Signed-off-by: Lubo Litchev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered on #17476 (comment), this is needed to avoid an error running
iree-import-onnxon certain test files:If we care about supporting older onnx package versions, we could add some fallback code to
iree-import-onnx.We may also want to update the version used in torch-mlir? https://github.com/llvm/torch-mlir/blob/e0a5adb1db38b0072c44b87570bc530eb3b324ad/setup.py#L264