-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flow] Fold flow reshape with mismatching dyn dims #18680
base: main
Are you sure you want to change the base?
Conversation
`flow.tensor.reshape` is foldable when there is a single mismatching dynamic dimension (unequal SSA values) because they must be the same. Signed-off-by: Ian Wood <[email protected]>
51c7a8b
to
48c6ee6
Compare
Signed-off-by: Ian Wood <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I missing something here. The test added here does not seem to be an example of what is described in the PR description?
Are you looking at |
Ah interesting. I did miss that, I see now. I dont know how this change made |
flow.tensor.reshape
is foldable when there is a single mismatching dynamic dimension (unequal SSA values) because they must be the same.Cleans up pattern found in migx_bert-large-uncased