Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/Tests failing #215

Merged
merged 4 commits into from
Oct 23, 2023
Merged

CI/Tests failing #215

merged 4 commits into from
Oct 23, 2023

Conversation

gordonwatts
Copy link
Member

@gordonwatts gordonwatts commented Oct 23, 2023

They just started failing quietly a few months ago. This PR will get everything working again.

  • Fixed issues where black had reformatted code so that we couldn't tell where one method started and the other ended.
  • Modern version of flake8 is catching more errors now.
  • The python 3.7 on macOS failure may have been suprious - it seems to work currently on the CI infrastructure.

Fixes #214

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a284336) 95.15% compared to head (242e8f0) 95.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
- Coverage   95.15%   95.05%   -0.11%     
==========================================
  Files          35       35              
  Lines        1880     1880              
  Branches      249      249              
==========================================
- Hits         1789     1787       -2     
- Misses         59       60       +1     
- Partials       32       33       +1     
Flag Coverage Δ
unittests 95.05% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
func_adl_xAOD/common/ast_to_cpp_translator.py 88.04% <100.00%> (-0.42%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gordonwatts gordonwatts merged commit 9e7007b into master Oct 23, 2023
39 of 40 checks passed
@gordonwatts gordonwatts deleted the pr_citest_fixes branch October 23, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI/Tests failing
1 participant