-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[irods/irods#7265] Minor reorganization + CMake TLC #155
Conversation
e174396
to
81b5e16
Compare
Ignore that PR. I have to do more investigation before that can be merged. If this work is ready for review, let's go ahead and take it out of draft. |
Done |
Once this PR is merged, please create a 4-3-stable branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to ignore the suggested name change. I think everything looks fine as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Pound it.
- Project tree structure reorganized to resemble that of main irods repo. - Added quotes around paths in CMake files. - Removed CMAKE_SHARED_LINKER_FLAGS_INIT and CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT, as no shared libraries are built. - Removed unused postinst script for nonexistent data_world package - Removed rpm package dependency declaration on openssl - Fixed postinst CPack variables
81b5e16
to
752f650
Compare
#'d |
4-3-stable branch created based on 8ac1fa1 |
In service of irods/irods#7265
This does not break compatibility with 4.3.1.
I didn't notice that there was still an open PR (#141) until just now, so I'd prefer to wait until that is merged and then rebase.