Phil Working #3
Open
Phil Working #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not done, change robot cotainer
offsets
iefomit
requested review from
Kyle-Eldridge,
chem7397,
Saara21 and
johaj10
as code owners
johaj10
requested changes
Nov 13, 2024
| autoCommand.addOption("3.5 piece [V2]", new FollowPathCommand("3.5 piece [V2]",true, drive)); | ||
| autoCommand.addOption("1 piece", new SequentialCommandGroup(prepare(),new WaitCommand(3),index(),new WaitCommand(2),new PrepareShooter(shooter, 0))); | ||
| // autoCommand.setDefaultOption("Do nothing", new DoNothing()); | ||
| // autoCommand.addOption("5 piece (original-tested)", new FollowPathCommand("5 piece (original-tested)",true, drive)); |
There was a problem hiding this comment.
Are we intending to remove the options for auto commands on all robots (including Vivace)? This looks like it will prevent any auto command options from showing on Shuffleboard. Just want to make sure I understand properly.
There was a problem hiding this comment.
Yes. Defining these causes problems when running on Phil and causes the code to crash. Although we could add if statements instead, unless we plan to run our autos from last year (without a speaker), we don't need these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR will run the Phil Robot.
Design Doc
Tests Ran
Launched Phil during driver practice.
Additional Notes