Send assets flow #20
Merged
Send assets flow #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dgca
commented
Oct 31, 2023
dgca
commented
dgca
commented
Oct 31, 2023
| @@ -0,0 +1,114 @@ | |||
| import { BoxKeyPair } from "@ironfish/rust-nodejs"; | |||
There was a problem hiding this comment.
Just renamed this file from /ironfish/index.ts to /ironfish/Ironfish.ts to keep the pattern of index files being route handlers.
dgca
commented
Oct 31, 2023
| @@ -0,0 +1,56 @@ | |||
| import { | |||
There was a problem hiding this comment.
The only real change in the /main/api/ folder is this new file that handles sending a transaction to the Iron Fish node.
dgca
commented
Oct 31, 2023
dguenther
reviewed
Nov 1, 2023
| toAccount: data.toAccount, | ||
| assetId: data.assetId, | ||
| amount: parseIron(data.amount), | ||
| fee: parseInt(fee, 10), |
There was a problem hiding this comment.
Ore values should be treated as bigints rather than numbers (since they're i64 values). It's unlikely to be an issue with fees anytime soon, since supply of the native currency is lower, and fees in general are low, but might be worth standardizing all operations on ORE/IRON everywhere to avoid any accidental parsing bugs, like the parseIron function you have above
dguenther
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.