Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passes wallet passphrase from CLI to migrator #5631

Merged
merged 2 commits into from
Nov 19, 2024

Commits on Nov 14, 2024

  1. passes wallet passphrase from CLI to migrator

    adds an error type, EncryptedWalletMigrationError, and catches errors of that
    type in the three commands that run migrations: 'migrations:start',
    'migrations:revert', and 'start'
    
    prompts user to enter wallet passphrase and passes passphrase through to
    migrator
    
    to support passing the passphrase down to the migrator in the 'start' command we
    pass the passphrase through 'NodeUtils.waitForOpen' and the the node's 'openDB' method
    
    supports implementing database migrations that handle encrypted wallet logic.
    for example, throwing the EncryptedWalletMigrationError on an encrypted account
    and using the wallet passphrase passed to 'migrate' to decrypt and re-encrypt
    the wallet
    hughy committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c769ea0 View commit details
    Browse the repository at this point in the history
  2. removes passphrase prompt from start command

    displays error message to user instead
    
    removes logic plumbing passphrase through openDB to migrator
    hughy committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    fa3756f View commit details
    Browse the repository at this point in the history